Skip to content

bump Gateway API v1.5.0-rc.1#8161

Open
zirain wants to merge 23 commits intoenvoyproxy:mainfrom
zirain:e2e-fail-fast
Open

bump Gateway API v1.5.0-rc.1#8161
zirain wants to merge 23 commits intoenvoyproxy:mainfrom
zirain:e2e-fail-fast

Conversation

@zirain
Copy link
Member

@zirain zirain commented Feb 3, 2026

  • Move test to a separated package to decoupe the sigs.k8s.io/gateway-api and sigs.k8s.io/gateway-api/conformance
  • Move internal/gatewayapi/conformace under test, it's not used, and production shouldn't rely on conformance.

@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit c8744e0
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6992638b193c17000846cd28

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 67.68559% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.93%. Comparing base (42825c7) to head (329490a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/runner/runner.go 5.55% 14 Missing and 3 partials ⚠️
internal/provider/kubernetes/indexers.go 64.10% 4 Missing and 10 partials ⚠️
internal/provider/kubernetes/controller.go 64.86% 6 Missing and 7 partials ⚠️
internal/provider/kubernetes/routes.go 18.75% 9 Missing and 4 partials ⚠️
internal/gatewayapi/resource/resource.go 14.28% 5 Missing and 1 partial ⚠️
internal/provider/kubernetes/status.go 33.33% 4 Missing and 2 partials ⚠️
internal/gatewayapi/xlistenerset.go 90.38% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8161      +/-   ##
==========================================
+ Coverage   73.88%   73.93%   +0.05%     
==========================================
  Files         241      239       -2     
  Lines       36609    36523      -86     
==========================================
- Hits        27047    27003      -44     
+ Misses       7656     7609      -47     
- Partials     1906     1911       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain force-pushed the e2e-fail-fast branch 2 times, most recently from 5c438ec to 71d124b Compare February 3, 2026 12:21
@zirain zirain changed the title e2e: fail fast chore: decoupe conformance package Feb 4, 2026
@zirain zirain changed the title chore: decoupe conformance package chore: decouple conformance package Feb 4, 2026
@zirain zirain force-pushed the e2e-fail-fast branch 3 times, most recently from b71c336 to a36af69 Compare February 6, 2026 01:20
@zirain zirain changed the title chore: decouple conformance package e2e: decouple conformance package Feb 6, 2026
@zirain zirain marked this pull request as ready for review February 6, 2026 01:25
@zirain zirain requested a review from a team as a code owner February 6, 2026 01:25
@arkodg arkodg added this to the v1.8.0-rc.1 Release milestone Feb 8, 2026
@zirain zirain changed the title e2e: decouple conformance package e2e: bump Gateway API v1.5.0-rc.1 Feb 13, 2026
@zirain zirain changed the title e2e: bump Gateway API v1.5.0-rc.1 bump Gateway API v1.5.0-rc.1 Feb 13, 2026
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the e2e-fail-fast branch 2 times, most recently from cc02c98 to bd0bbfe Compare February 14, 2026 01:10
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the e2e-fail-fast branch 2 times, most recently from 0c478ed to 7ced098 Compare February 14, 2026 06:33

// GatewayAPI defines an experimental Gateway API resource that can be enabled.
// +enum
// +kubebuilder:validation:Enum=XListenerSet;XBackendTrafficPolicy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XListenerSet promote to v1 in Gateway API v1.5

Copy link
Contributor

@arkodg arkodg Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing this is the breaking change because even if a user wants to stay on XListenerSet, then cant ? and must migrate to ListenerSet when upgrading to v1.8 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, If we need rethink about this in the future, do we need to support X API.

Copy link

@maelvls maelvls Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for what it's worth, we (cert-manager) have decided to do a clean cut upgrade to ListenerSet as opposed to keeping both resources. There was a discussion on whether to keep the X resources around in 1.5: https://kubernetes.slack.com/archives/CR0H13KGA/p1770328007249819

Copy link
Member

@zhaohuabing zhaohuabing Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to removing XListenerSet support from 1.8 since we've already set expectations in the GatewayAPISettings that These APIs are experimental today and are subject to change or removal as they mature.

Maintaining both XListenerSet and ListenerSet would add quite a bit of ongoing overhead, and it might not be worth keeping both around.

- attachedRoutes: 0
conditions:
- lastTransitionTime: null
message: Listener must have TLS set when protocol is TLS.
Copy link
Member Author

@zirain zirain Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gateway API add CEL validation for this.

@zirain zirain force-pushed the e2e-fail-fast branch 3 times, most recently from 0629b69 to 883882a Compare February 14, 2026 08:44
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Comment on lines +19 to +40
// TODO: fix following conformance tests
tests.ListenerSetHostnameConflict,
tests.ListenerSetProtocolConflict,
tests.TLSRouteHostnameIntersection,
tests.TLSRouteInvalidNoMatchingListener,
tests.TLSRouteInvalidNoMatchingListenerHostname,
tests.TLSRouteInvalidReferenceGrant,
tests.TLSRouteListenerTerminateSupportedKinds,
tests.TLSRouteSimpleSameNamespace,
tests.TLSRouteTerminateSimpleSameNamespace,
tests.TLSRouteMixedTerminationSameNamespace,
tests.GatewayInvalidTLSBackendConfiguration,
tests.GatewayWithAttachedRoutes,
tests.GatewayTLSBackendClientCertificate,
tests.GatewayFrontendClientCertificateValidation,
tests.GatewayInvalidFrontendClientCertificateValidation,
tests.GatewayFrontendInvalidDefaultClientCertificateValidation,
tests.HTTPRouteHTTPSListenerDetectMisdirectedRequests,
tests.HTTPRoute303Redirect,
tests.HTTPRoute307Redirect,
tests.HTTPRoute308Redirect,
tests.HTTPRouteHostnameIntersection,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Tracked in seperated issue.

- {{ include "eg.rbac.namespaced.gateway.envoyproxy.status" . | nindent 2 | trim }}
- {{ include "eg.rbac.namespaced.gateway.networking" . | nindent 2 | trim }}
- {{ include "eg.rbac.namespaced.gateway.networking.status" . | nindent 2 | trim }}
- {{ include "eg.rbac.namespaced.gateway.networking.experimental" . | nindent 2 | trim }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why these are removed

resourceType: string(EndpointEnvoyConfigType),
expect: true,
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


var (
//go:embed charts/gateway-helm/crds/gatewayapi-crds.yaml
//go:embed gatewayapi-crds.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuirous why are we moving this out of chart

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gatewayapi-crds is large than 1MB, which make helm install never success.
Because helm store the release info in secret(the default driver), which have 1MB limitation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping the CRDs in gateway-helm is still useful — at least for development and testing workflows.

Does #8283 help?

@arkodg
Copy link
Contributor

arkodg commented Feb 14, 2026

hey thanks for driving this work !
this one PR is trying to do a lot, is it possible to split up into smaller parts ?

is the plan to rm all CRDs from gateway-helm and recommend users to use gateway-crds-helm starting v1.8 ?
cc @envoyproxy/gateway-maintainers

@zirain
Copy link
Member Author

zirain commented Feb 15, 2026

hey thanks for driving this work ! this one PR is trying to do a lot, is it possible to split up into smaller parts ?

It's hard, most of them are related to bump Gateway API v1.5.
sigs.k8s.io/gateway-api/conformance now is a seperated package.

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Copy link
Member Author

zirain commented Feb 15, 2026

/retest

1 similar comment
@jukie
Copy link
Contributor

jukie commented Feb 15, 2026

/retest

Signed-off-by: zirain <zirain2009@gmail.com>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this file be renamed to listenerset.go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that is right.
let's do that in seperated PR.

@zhaohuabing
Copy link
Member

is the plan to rm all CRDs from gateway-helm and recommend users to use gateway-crds-helm starting v1.8 ?
cc @envoyproxy/gateway-maintainers

I think keeping the CRDs in gateway-helm is still useful — at least for development and testing workflows.

Does #8283 help?

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we watch TLSRoute v1 instead of v1alpha3?

Continuing watching v1alpha3 would break standard channel users as it's not in standard channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments